This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove CPU mask size detection from setaffinity
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>
- Date: Wed, 20 May 2015 18:34:01 +0200
- Subject: Re: [PATCH] Remove CPU mask size detection from setaffinity
- Authentication-results: sourceware.org; auth=none
- References: <555CB525 dot 6050505 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1505201627021 dot 23246 at digraph dot polyomino dot org dot uk>
On 05/20/2015 06:27 PM, Joseph Myers wrote:
> On Wed, 20 May 2015, Florian Weimer wrote:
>
>> The code looks quite broken to me and fails to achieve what it tries to
>> do, as explained in the commit message.
>
> If there's a bug here that was user-visible in releases, it should be
> filed in Bugzilla and the appropriate [BZ #N] notation / addition to list
> of fixed bugs in NEWS added.
The existing bugs are not visible to applications. There is a behavior
difference (fewer EINVAL returns), and the new behavior is more
consistent. Or put differently, the kernel does not allow us to
implement the intended behavior, so if there is a bug, this patch does
not fix it.
--
Florian Weimer / Red Hat Product Security