This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove CPU mask size detection from setaffinity
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>
- Date: Thu, 21 May 2015 13:28:51 +0200
- Subject: Re: [PATCH] Remove CPU mask size detection from setaffinity
- Authentication-results: sourceware.org; auth=none
- References: <555CB525 dot 6050505 at redhat dot com>
On 05/20/2015 06:24 PM, Florian Weimer wrote:
> The code looks quite broken to me and fails to achieve what it tries to
> do, as explained in the commit message.
Another advantage is that the magic number 1024 (128 bytes of CPU bits)
is gone, so testing on smaller machines is possible.
Well, I did that (144 CPU cores, detected set size 192 bits), and it
turns out that my pthread test case is completely broken. :-(
Here's a new one. It tries to check that the active CPU set returned by
the kernel has not been truncated, and that threads are not scheduled to
CPUs outside the set.
--
Florian Weimer / Red Hat Product Security