This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/8] Function declaration cleanup

On 06-01-2015 14:25, H.J. Lu wrote:
> On Thu, Oct 9, 2014 at 10:14 AM, Roland McGrath <> wrote:
>>> On 08-10-2014 18:52, Roland McGrath wrote:
>>>> This sort of change should get the "no disassembly of compiled code
>>>> changed" test rather than the vanilla "no regressions" test.  With that
>>>> testing, changes like this can count as "obvious enough".
>>> Thanks, I compared the dissassembly of compiled code and it shows no change.
>>> Is that ok to apply?
>> Yes.  What I meant to communicate is that whenever you have a
>> prototypification change, just verifying that it doesn't change the
>> compiled code is enough to commit it without explicit approval from
>> another person.  (Of course it never hurts to let people look it over for
>> typos or bad indentation or whatever, but when you're confident you got
>> those trivia correct, you can just commit without waiting for replies.)
> I am cleaning up patchwork queue.  I checked in this patch.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]