This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Ignore warning in string/tester.c.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 6 Jan 2015 17:45:32 +0100
- Subject: Re: [PATCH] Ignore warning in string/tester.c.
- Authentication-results: sourceware.org; auth=none
- References: <1418670947 dot 7165 dot 1 dot camel at triegel dot csb>
On Mon, Dec 15, 2014 at 08:15:47PM +0100, Torvald Riegel wrote:
> This fixes a warning in a build using a fairly recent GCC. AFAIK the
> warning/option is new and hasn't been offered by 4.9, hence the
> conditional. OK?
I also got warning in debian gcc-4.9 so I commited following as obvious.
diff --git a/ChangeLog b/ChangeLog
index 2edda5e..8f569ce 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@
* sysdeps/unix/sysv/linux/check_pf.c (make_request):
Clean up check_pf allocation pattern. addresses
+ * string/tester.c (test_memset): Suppress warning for gcc 4.9
2015-01-06 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
diff --git a/string/tester.c b/string/tester.c
index f957ed2..64dc056 100644
--- a/string/tester.c
+++ b/string/tester.c
@@ -1305,10 +1305,10 @@ test_memset (void)
equal(one, "axxxefgh", 2); /* Basic test. */
DIAG_PUSH_NEEDS_COMMENT;
-#if __GNUC_PREREQ (5, 0)
- /* GCC 5.0 warns about a zero-length memset because the arguments to memset
+#if __GNUC_PREREQ (4, 9)
+ /* GCC 4.9 warns about a zero-length memset because the arguments to memset
may be in the wrong order. But we really want to test this. */
- DIAG_IGNORE_NEEDS_COMMENT (5.0, "-Wmemset-transposed-args")
+ DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmemset-transposed-args")
#endif
(void) memset(one+2, 'y', 0);
equal(one, "axxxefgh", 3); /* Zero-length set. */