This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add more headers to include/ for conform tests
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Fri, 28 Nov 2014 21:16:26 -0500
- Subject: Re: Add more headers to include/ for conform tests
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411272041480 dot 15307 at digraph dot polyomino dot org dot uk> <5478CCDA dot 2040904 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1411282351150 dot 30652 at digraph dot polyomino dot org dot uk> <547910BE dot 3030206 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1411290147530 dot 30652 at digraph dot polyomino dot org dot uk>
On 11/28/2014 08:53 PM, Joseph Myers wrote:
> On Fri, 28 Nov 2014, Carlos O'Donell wrote:
>
>> On 11/28/2014 06:52 PM, Joseph Myers wrote:
>>> On Fri, 28 Nov 2014, Carlos O'Donell wrote:
>>>
>>>> Now I have only 200+ linknamespace failures :-)
>>>
>>> What are those failures (what error messages where)? At least on
>>> x86_64/x86, all the non-XFAILed tests ought to be passing (though the same
>>> include/ patch may be needed for them).
>>
>> As an example on 32-bit ARM:
>>
>> conform/ISO/assert.h/linknamespace.out:
>>
>> [initial] __assert_fail -> [libc.a(assert.o)] __fxprintf -> [libc.a(fxprintf.o)] __vfwprintf -> [libc.a(vfwprintf.o)] _IO_fwide -> [libc.a(iofwide.o)] __pointer_chk_guard_local -> [libc.a(libc-start.o)] __pthread_initialize_minimal -> [libpthread.a(nptl-init.o)] __nptl_setxid_error -> [libpthread.a(pthread_create.o)] __resp -> [libc.a(res_libc.o)] __res_iclose -> [libc.a(res_init.o)] fgets_unlocked
>
> I hope the patch I just committed
> <https://sourceware.org/ml/libc-alpha/2014-11/msg00889.html> will fix many
> of these. (However, such symbols appear in many of the existing XFAILed
> cases that end up bringing in the resolver etc. - they reflect genuine
> architecture-independent namespace bugs, it's just the appearance in this
> particular case that's architecture-specific.)
Thanks. I'm retesting with your patch.
>> [initial] __assert_fail -> [libc.a(assert.o)] _dl_pagesize -> [libc.a(dl-support.o)] _dl_nothread_init_static_tls -> [libc.a(dl-reloc.o)] _dl_runtime_profile -> [libc.a(dl-trampoline.o)] _dl_call_pltexit -> [libc.a(dl-runtime.o)] _dl_mcount -> [libc.a(dl-profile.o)] __profil -> [libc.a(profil.o)] profil_counter
>
> This looks like an ordinary architecture-specific bug, however. (On
> architectures where profil_counter is not static, i.e. ARM and SPARC, it
> should be a weak alias for __profil_counter.)
Agreed.
Cheers,
Carlos.