This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Add more headers to include/ for conform tests

Carlos reported failures in conform/ tests in environments where the
compiler used could only find headers in glibc's source and build
trees, not any previously installed headers

This patch adds wrappers for the affected headers to include/, which
is the normal way to make headers visible when building or testing in
directories other than the one containing the header (I suppose these
headers weren't needed in any such directories except conform/, or
other build or test failures would have resulted).  I believe the same
issue applies at least to regexp.h and re_comp.h - we don't currently
have conform/ expectations for those, but when such expectations are
added we'll also need to add header wrappers.

The semaphore.h wrapper just includes nptl/semaphore.h - there's a
question about whether this is logically correct, given the
possibility of other thread library implementations.  I suggested a
couple of possible alternative approaches in

Tested for x86_64 (testsuite, and that installed stripped shared
libraries are unchanged by the patch).  I did *not* test a
configuration such as that in which Carlos saw failure.

2014-11-27  Joseph Myers  <>

	* include/cpio.h: New file.
	* include/fmtmsg.h: Likewise.
	* include/semaphore.h: Likewise.

diff --git a/include/cpio.h b/include/cpio.h
new file mode 100644
index 0000000..38e2ed1
--- /dev/null
+++ b/include/cpio.h
@@ -0,0 +1 @@
+#include <posix/cpio.h>
diff --git a/include/fmtmsg.h b/include/fmtmsg.h
new file mode 100644
index 0000000..6ac606d
--- /dev/null
+++ b/include/fmtmsg.h
@@ -0,0 +1 @@
+#include <stdlib/fmtmsg.h>
diff --git a/include/semaphore.h b/include/semaphore.h
new file mode 100644
index 0000000..01c7ba1
--- /dev/null
+++ b/include/semaphore.h
@@ -0,0 +1 @@
+#include <nptl/semaphore.h>

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]