This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/N] [x86_64] Vectorized math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 26 Nov 2014 16:53:49 +0000
- Subject: Re: [PATCH 3/N] [x86_64] Vectorized math functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3ueRnbLVeTh9BrU27hwwdU=WEsrN7iC0o=c6d53mbsz6A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1411211757030 dot 2475 at digraph dot polyomino dot org dot uk> <CAMXFM3vbyrZ-iUR5Kd7L8CMakpn+ObdTeKTYkfLj+Uzt3v5GEQ at mail dot gmail dot com>
On Mon, 24 Nov 2014, Andrew Senkevich wrote:
> @@ -113,9 +113,10 @@ ulps-file = $(firstword $(wildcard
> $(sysdirs:%=%/libm-test-ulps)))
> $(addprefix $(objpfx), $(libm-tests-generated)): $(objpfx)libm-test.stmp
>
> $(objpfx)libm-test.stmp: $(ulps-file) libm-test.inc gen-libm-test.pl \
> - auto-libm-test-out
> + gen-libm-have-vector-test.sh auto-libm-test-out
> $(make-target-directory)
> $(PERL) gen-libm-test.pl -u $< -o "$(objpfx)"
> + $(BASH) gen-libm-have-vector-test.sh > $(objpfx)libm-have-vector-test.h
I don't see anything bash-specific in this script, so $(SHELL) seems more
appropriate.
> +# Generate series of definitions used for vector math functions tests.
> +print_defs()
> +{
> + echo "#if defined TEST_VECTOR_$1 && TEST_VECTOR_$1"
> + echo "# define HAVE_VECTOR_$1 1"
> + echo "# define ${1}_VEC_SUFF WRAPPER_NAME($1)"
Space before '(' in call to WRAPPER_NAME.
> + echo "#else"
> + echo "# define HAVE_VECTOR_$1 0"
> + echo "# define ${1}_VEC_SUFF $1"
> + echo "#endif"
> + echo
I think more explanation is needed in a comment about where the
TEST_VECTOR_* macros, and WRAPPER_NAME, come from.
Also, where is the ${1}_VEC_SUFF macro used?
Again, it would be helpful if you had a git branch with the latest rebased
version of this patch series, updated each time a patch changed, so we
could see where this is heading. See
<https://sourceware.org/glibc/wiki/GlibcGit>: branches under the
<username>/ namespace can be freely created and deleted.
--
Joseph S. Myers
joseph@codesourcery.com