This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix sysdeps/mips/__longjmp.c warning

This patch fixes

../sysdeps/mips/__longjmp.c:27:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]

which arose I think from the MIPS16 changes (renaming the function to
____longjmp with an alias __longjmp, so a prior header prototype for
__longjmp no longer sufficed to prevent a warning).  I've made the
function use a prototype definition, which is what we want for all
function definitions in glibc anyway.

Tested for MIPS and committed.

2014-11-26  Joseph Myers  <>

	* sysdeps/mips/__longjmp.c (____longjmp): Use prototype

diff --git a/sysdeps/mips/__longjmp.c b/sysdeps/mips/__longjmp.c
index 5e6a353..c2498c3 100644
--- a/sysdeps/mips/__longjmp.c
+++ b/sysdeps/mips/__longjmp.c
@@ -24,9 +24,7 @@
 static void __attribute__ ((nomips16))
-____longjmp (env_arg, val_arg)
-     __jmp_buf env_arg;
-     int val_arg;
+____longjmp (__jmp_buf env_arg, int val_arg)
   /* gcc 1.39.19 miscompiled the longjmp routine (as it did setjmp before
      the hack around it); force it to use $a1 for the longjmp value.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]