This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] arm: do not abort EABI check for bootstrapping
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 20 Nov 2014 13:36:57 -0800 (PST)
- Subject: Re: [PATCH] arm: do not abort EABI check for bootstrapping
- Authentication-results: sourceware.org; auth=none
- References: <1416468692-4317-1-git-send-email-vapier at gentoo dot org> <20141120175902 dot 426FF2C3B2F at topped-with-meat dot com> <20141120181950 dot GB3743 at vapier dot wh0rd dot info> <20141120183654 dot DC12D2C3B2F at topped-with-meat dot com> <20141120200805 dot GC3743 at vapier dot wh0rd dot info> <20141120205438 dot 9D3A22C3B2C at topped-with-meat dot com> <20141120212715 dot GF3743 at vapier dot wh0rd dot info>
> so from glibc's perspective, "not our problem" ;)
That was also so. What I pointed out is that it's also only a problem for
you because you decided it was. You can instead just decide not to care
about the gratuitous rebuild of the compiler.
> i certainly cannot disagree with the specific fragiliness of my proposed
> change. the difference with this check compared to just about every
> other one is that it lacks a cache var wrapping as well as fallback
> logic.
I'd certainly have no objection to a change to wrap AC_CACHE_CHECK around it.
> the change in this file was done under the heading of simplification
> where the supposition is that checking CPP defines is more reliable than
> the target tuple.
It is so in the sense of long-term maintainability. If what we care about
is how the compiler is behaving, then checking the compiler keeps it
proximate rather than one or (many) more steps removed from where the
actual decision is made. The exact meanings of tuples change over time,
and some packages are more sensitive than others to the exact tuple.
> but if binutils & gcc (and glibc in some places) hard require the form of
> the tuple in order to get certain behavior, why should we be different ?
> checking the tuple for *-gnueabi is certainly faster than compiling code
> :).
binutils has no other target-specific prerequisite to go on. GCC has none
but binutils.