This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]


(cc'ing Arnd)

On Wed, Nov 19, 2014 at 04:42:59PM +0000, Marcus Shawcroft wrote:
> On 14 November 2014 10:15, Renlin Li <> wrote:
> > This patch duplicates sysdeps/unix/sysv/linux/bits/sigstack.h into
> > sysdeps/unix/sysv/linux/aarch64/bits/sigstack.h and modifies only SIGSTCKSZ
> >
> > The ucontext_t is 4560 bytes, siginfo_t is 128 bytes. The required sigframe
> > is far larger than the current default MINSIGSTKSZ (which is 2048). Thus, I
> > increase MINSIGSTKSZ to 8192, and adjust SIGSTCKSZ accordingly.
> >
> > Glibc has been build and test on the model, no new issues.
> >
> > Okay to commit?
> >
> > ChangeLog:
> >
> > 2014-11-14  Renlin Li  <>
> >     [BZ #16850]
> >     * sysdeps/unix/sysv/linux/aarch64/bits/sigstack.h: New.
> Catalin,  We need to lift raise the values of MINSIGSTKSZ and
> SIGSTCKSZ the former is currently smaller than a signal frame which
> makes it  unusable.  These are defined in both glibc and in the kernel
> but should be kept in sync.  The proposal in glibc is to lift these to
>  8192 and 18384 respectively.  Thoughts?

The arm64 port uses the generic values but they could be defined,
probably with some #ifdef in the generic signal.h file.

There is however a slight ABI change as the do_sigaltstack() Linux
implementation checks whether the user ss_size is smaller than
MINSIGSTKSZ and exits. If we assume that the user code with a 2KB/4KB
ss_size for sigaltstack was already broken, we can make this change. But
I'd like to see Arnd's opinion as well.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]