This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Remove Wundef warnings for specification macros

On 09/19/2014 12:20 PM, Siddhesh Poyarekar wrote:
+$(objpfx)confdefs-defs.h: conf.list Makefile
+	$(make-target-directory)
+	$(AWK) -f $(..)scripts/gen-conf.awk $< > $@.tmp
+	mv -f $@.tmp $@

Missing dependency on $(..)scripts/gen-conf.awk, I think.

diff --git a/posix/conf.list b/posix/conf.list
new file mode 100644
index 0000000..d048568
--- /dev/null
+++ b/posix/conf.list
@@ -0,0 +1,23 @@
+# Configuration variables identified by getconf.  The heading of each section
+# is of the format TYPE:PREFIX:SC_PREFIX with the opening curly brace on the
+# same line.  TYPE can either be SYSCONF, PATHCONF, CONFSTR or SPEC.  In the
+# absence of SC_PREFIX, _SC is used as the SC_PREFIX.  Variable names are put
+# one on each line with a curly brace on its own line ending the section.

“SPEC:POSIX” does not match the “TYPE:PREFIX:SC_PREFIX” pattern. Looking at the awk script, “:SC_PREFIX” appears superfluous.

   #ifdef __ILP32_OFF32_CFLAGS
   #  error "__ILP32_OFF32_CFLAGS should not be defined"

I wonder what the purpose of these #errors are. Is this intended to help with porting?

Florian Weimer / Red Hat Product Security

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]