This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: additional unlink hardening for non-small bins [BZ #17344]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Chris Evans <cevans at google dot com>
- Date: Wed, 10 Sep 2014 20:39:04 +0200
- Subject: Re: [PATCH] malloc: additional unlink hardening for non-small bins [BZ #17344]
- Authentication-results: sourceware.org; auth=none
- References: <541014A3 dot 3020806 at redhat dot com> <20140910181038 dot 5EBF12C39CB at topped-with-meat dot com>
On 09/10/2014 08:10 PM, Roland McGrath wrote:
I think it's best practice to put each condition inside a __builtin_expect
separately, rather than to have a complex expression inside it (despite the
contrary example a few lines up). The change seems fine aside from that.
Thanks. The generated code is the same, so I'm going to commit the
version with two __builtin_expect expressions.
(Eventually, we have to convert malloc/ to __glibc_{,un}likely.)
--
Florian Weimer / Red Hat Product Security