This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Should we continue to hold up 2.20 for -Wundef fixes?
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 03 Sep 2014 11:58:13 -0400
- Subject: Should we continue to hold up 2.20 for -Wundef fixes?
- Authentication-results: sourceware.org; auth=none
Roland,
TL;DR: Lets not block 2.20 any more on -Wundef changes?
I think the -Wundef fixes are great. Siddhesh has put quite a lot
of work into them to take us to the point where we can turn the
warning into an error.
The question we have to ask ourselves now is: Should any more of
these changes go into 2.20 before release or should be just stop,
make 2.20, and continue later.
I promise you we'll get the changes into 2.21 as soon as it opens,
and we can make good on turning this into an error in 2.21. I'm
reviewing Siddhesh's most recently unreviewed -Wundef patches,
so I'll drive that to completion.
I think 2.20 should go out with whatever -Wundef fixes we currently
have in place, and no more.
Cheers,
Carlos.