This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Eliminate third argument from _JMPBUF_UNWINDS

Roland McGrath <> writes:

>> Roland McGrath <> writes:
>> > This all but ensures that when a machine adds PTR_MANGLE/PTR_DEMANGLE
>> > support, or changes how it does the mangling, that the corresponding
>> > update in jmpbuf-unwind.h will be forgotten.
>> That will not happen.
> Your assertion alone does not reassure me.  
> What guarantees this will not happen?

Because I obviously didn't change anything here.  If you think there is
something wrong then it's not my fault.

> In the current scheme the caller does not have knowledge of jmp_buf
> internals.  It is required to supply a function that performs PTR_DEMANGLE.
> That's all it knows.  _JMPBUF_UNWINDS has the knowledge of how that
> function is useful in interpreting a jmp_buf.

It is still a layering violation and bad code duplication.  The callers
are not suposed to know about the mangling.  Moreover, the macros is
useless without demangling.


Andreas Schwab,
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]