This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED PATCH] Get rid of nptl/sysdeps/pthread/ subdirectory

On 06/12/2014 11:02 PM, Roland McGrath wrote:
This directory never should have existed even for the add-on.  This
conflated three different kinds of things, which are now separated:

* Things that depend only on the public pthread.h API
   -> sysdeps/pthread/
* Things that depend on NPTL implementation details
   -> sysdeps/nptl/
* Parts of the NPTL implementation itself
   -> nptl/ (include/ for list.h)

Verified on x86_64-linux-gnu and i686-linux-gnu that there are no code
changes except for getting some offset adjustments because
the assertion file name strings in its .rodata changed.

I've also grepped for potentially affected #include's for other
configurations.  There are two, both of which are moot after other pending
patches on the roland/nptl-ia64 and roland/nptl-microblaze branches.  So
the ia64 and microblaze builds are broken now, and will be fixed by their
maintainers reviewing and approving the machine-specific patches I have
already posted.


Hi Roland,
the test begin-end-check fails after this patch due to missing file: nptl/sysdeps/pthread/pthread.h. I have adjusted the Makefile variable installed-headers to the new location of the header.
Tested on s390.
Please retest and commit.

2014-06-13  Stefan Liebler  <>

	* Makefile (installed-header):
	Adjust path of pthread.h header.

Attachment: test_begin-end-check-pthread_h
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]