This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch not showing in patchwork

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: Pedro Alves <palves at redhat dot com>, libc-alpha at sourceware dot org
Date: Wed, 11 Jun 2014 18:25:36 +0530
Subject: Re: Patch not showing in patchwork
Authentication-results: sourceware.org; auth=none
References: <Pine dot LNX dot 4 dot 64 dot 1406101636120 dot 8581 at digraph dot polyomino dot org dot uk> <53976045 dot 8050602 at redhat dot com> <20140611103312 dot GE24193 at spoyarek dot pnq dot redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1406111205440 dot 21319 at digraph dot polyomino dot org dot uk>

On Wed, Jun 11, 2014 at 12:11:12PM +0000, Joseph S. Myers wrote:
> On Wed, 11 Jun 2014, Siddhesh Poyarekar wrote:
> 
> > +                try_charsets = ['utf-8', 'windows-1252', 'ascii', 'iso-8859']
> 
> I suspect you mean iso-8859-1.  (Both windows-1252 and iso-8859-1 provide 
> useful fallbacks for mixed-character-set patches - what's relevant is 
> actually the bytes of the patch, after all, when it's changing files that 
> don't all use the same character set, and misinterpreting those bytes as 
> the wrong characters doesn't matter so much.  This particular patch was 
> actually iso-8859-1 - +/- signs in pre-existing comments in patch 
> context.)

Thanks, fixed.

Siddhesh

Attachment: pgp2rRIrci3aX.pgp
Description: PGP signature

References:
- Patch not showing in patchwork
  - From: Joseph S. Myers
- Re: Patch not showing in patchwork
  - From: Pedro Alves
- Re: Patch not showing in patchwork
  - From: Siddhesh Poyarekar
- Re: Patch not showing in patchwork
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]