This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 21 May 2014 17:26:02 +0530
Subject: Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
Authentication-results: sourceware.org; auth=none
References: <CAGQ9bdzqT1EyXYMwACrHpPU=vPjM_b72LJRjb7BW_OzJRXG3bw at mail dot gmail dot com> <20140520131314 dot GB14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdw=-pzbi00gn5t_W8pXBjU0edFvLGMNUc+o=g9og=f9+Q at mail dot gmail dot com> <20140520144605 dot GE14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdz44LJM6SY83vwGEyOKHScOQor6xVJ1xADEOrcskhot7A at mail dot gmail dot com> <20140520154645 dot GI14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdzbSWwbfuKUV-0e3XkqsJ9-YEbKy_rHipaXuwaMe9mxUw at mail dot gmail dot com> <20140521114751 dot GO14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdzOZEcfMatwhSZssOn6esEd4xwKWJ_knDSU8-Mj_9DCgA at mail dot gmail dot com>

On Wed, May 21, 2014 at 03:48:32PM +0400, Konstantin Serebryany wrote:
> Let me prepare another patch then.

Let this patch go in as is.  Move the function out with the patch to
sha256-crypt.c or whatever you're changing next, assuming that this
patch is in.

> Does __b64_from_24bit declared in crypt-private.h and defined in
> crypt_util.c sound good?

Yes.

Siddhesh

Attachment: pgp2UBiNSglbO.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany

References:
- [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Siddhesh Poyarekar
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Siddhesh Poyarekar
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Siddhesh Poyarekar
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Siddhesh Poyarekar
- Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
  - From: Konstantin Serebryany

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]