This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Consistently include Makeconfig after defining subdir
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 27 Feb 2014 11:39:39 -0300
- Subject: Re: Consistently include Makeconfig after defining subdir
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1402182257230 dot 31862 at digraph dot polyomino dot org dot uk> <lenco8$5dg$1 at ger dot gmane dot org>
On 27-02-2014 09:57, Stefan Liebler wrote:
> I cannot build glibc on S390 due to failure:
> In file included from ../sysdeps/gnu/unwind-resume.c:19:0:
> ../sysdeps/gnu/unwind-resume.c: In function 'init':
> ../sysdeps/gnu/unwind-resume.c:35:27: error: 'LIBGCC_S_SO' undeclared (first use in this function)
> handle = __libc_dlopen (LIBGCC_S_SO);
>
> LIBGCC_S_SO is defined in gnu/lib-names.h,
> which will be generated due to Makeconfig:
> # Generate the header containing the names of all shared libraries.
> # We use a stamp file to avoid unnecessary recompilations.
> before-compile += $(common-objpfx)gnu/lib-names.h
>
> After moving "include ../Makeconfig" directly under "subdir := csu" in csu/Makefile, the variable before-compile is now overwritten by
> "before-compile = $(objpfx)version-info.h".
>
> IÂve tested this Patch on S390.
>
> Bye
>
> ---
> 2014-02-27 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> * csu/Makefile: Use += instead of a =.
> ---
>
I was about to report a similar issue for PPC32/PPC64. You patch fixes the build for my environment.