This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Notice clock_* functions in librt.so for old GLIBC_2.18 builds?
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Brooks Moses <bmoses at google dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 25 Feb 2014 11:41:27 -0500
- Subject: Re: Notice clock_* functions in librt.so for old GLIBC_2.18 builds?
- Authentication-results: sourceware.org; auth=none
- References: <53070029 dot 90407 at redhat dot com> <877g8opzuv dot fsf at igel dot home> <87y514oio2 dot fsf at igel dot home> <5307CB8F dot 4080507 at google dot com> <5307D2DD dot 702 at redhat dot com> <20140221235459 dot CDB4F744B4 at topped-with-meat dot com> <5307F2C3 dot 3020303 at redhat dot com> <20140222091630 dot 55C76744BC at topped-with-meat dot com> <m2y5138k22 dot fsf at linux-m68k dot org> <20140222193337 dot 4EAF674471 at topped-with-meat dot com>
On 02/22/2014 02:33 PM, Roland McGrath wrote:
>> Roland McGrath <roland@hack.frob.com> writes:
>>
>>> Also, someone should try turning on -Wundef in the build and see if it
>>> generates any warnings.
>>
>> Long way to go.
>
> Thanks for doing the exercise. That is disappointing indeed, but it
> doesn't look intractable. I think we should get started ASAP on piecemeal
> cleanup of these. Perhaps we should even put -Wundef in now so everybody
> has all the cases thrust before them, and change it to -Werror=undef
> eventually when we're done cleaning up.
>
> It probably makes sense to take them one macro at a time across all cases
> rather than files at a time. I suspect most are straightforward cases for
> s/if/ifdef/. Others (e.g. _POSIX_* et al) actually do properly want to be
> "#if defined foo && foo" and the like. At least a few seem like probable
> actual bugs from missing #includes, albeit almost certainly benign ones not
> affecting the #if resolution in actuality (RTLD_PRIVATE_ERRNO sticks out).
I agree. Enable -Wundef *right now* :-)
Cheers,
Carlos.