This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Notice clock_* functions in librt.so for old GLIBC_2.18 builds?


Andreas Schwab <schwab@linux-m68k.org> writes:

> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> The conditional is:
>> #if SHLIB_COMPAT (librt, GLIBC_2_2, GLIBC_2_17)
>>
>> Which should result in no code if the ABI starts at
>> GLIBC_2_17 or later.
>
> I think the problem is that there is no GLIBC_2.17 in Versions.def for
> librt.  If the minimum version is GLIBC_2.17 this is implicit, but with
> GLIBC_2.18 or later this doesn't work.

I have verified that after adding this the clock_* symbols disapper when
building with a minimum version of GLIBC_2.18.  I have installed this
patch.  Perhaps there is a way to automatically validate all uses of
SHLIB_COMPAT wrt. missing entries in Versions.def.

Andreas.

>From 9a80491d4931c9bc0f65887b7f67346f866cf1b9 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@linux-m68k.org>
Date: Fri, 21 Feb 2014 11:32:19 +0100
Subject: [PATCH] Add GLIBC_2.17 to librt in Version.def

This is needed because the version is used in SHLIB_COMPAT.
---
 ChangeLog    | 4 ++++
 Versions.def | 1 +
 2 files changed, 5 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index f7818fc..3f6828c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2014-02-21  Andreas Schwab  <schwab@linux-m68k.org>
+
+	* Versions.def (librt): Add GLIBC_2.17.
+
 2014-02-21  Adam Conrad  <adconrad@0c3.net>
 
 	* sysdeps/powerpc/bits/hwcap.h: Allow _SYSDEPS_SYSDEP_H guard as a
diff --git a/Versions.def b/Versions.def
index 759c754..9bb343f 100644
--- a/Versions.def
+++ b/Versions.def
@@ -124,6 +124,7 @@ librt {
   GLIBC_2.3.4
   GLIBC_2.4
   GLIBC_2.7
+  GLIBC_2.17
 }
 libutil {
   GLIBC_2.0
-- 
1.9.0

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]