This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/9] Add vectorized getenv for glibc use
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org, Andi Kleen <ak at linux dot intel dot com>
- Date: Mon, 13 May 2013 11:23:17 +0530
- Subject: Re: [PATCH 1/9] Add vectorized getenv for glibc use
- References: <1367537252-30831-1-git-send-email-andi at firstfloor dot org> <1367537252-30831-2-git-send-email-andi at firstfloor dot org> <20130509093313 dot GE19683 at spoyarek dot pnq dot redhat dot com> <20130510223240 dot GV17814 at two dot firstfloor dot org>
On Sat, May 11, 2013 at 12:32:40AM +0200, Andi Kleen wrote:
> On Thu, May 09, 2013 at 03:03:13PM +0530, Siddhesh Poyarekar wrote:
> > > + _dl_glibc_var;
> > > + __glibc_var_init;
> >
> > These should be sorted.
>
> FWIW the existing entries are not sorted. I moved my new ones.
Then they ought to be sorted and pushed as an obvious change before
your patch.
> > We might want to enforce namespaces from the beginning here. How
> > about GLIBC_PTHREAD_MUTEX_TYPE or similar? I don't want to bikeshed
> > on the actual name; I'm fine as long as a good namespace convention is
> > established.
>
> The environment variables are called GLIBC_MUTEX and GLIBC_RWLOCK
> I don't think it makes sense to call the internal names anything
> else.
Sorry, I guess I wasn't clear enough. I meant namespaces for the
environment variables since they are good candidates for inclusion
into generic tunables.
Siddhesh