This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] scsi/sg.h: include stddef.h for size_t
On 01/14/2013 01:20 PM, Mike Frysinger wrote:
> This header uses size_t but doesn't include stddef.h for it. So when
> packages happen to include this before any header that defines size_t,
> they get a build failure.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2013-01-12 Mike Frysinger <vapier@gentoo.org>
>
> * sysdeps/unix/sysv/linux/scsi/sg.h: Include stddef.h.
> ---
> v3
> - define __need_size_t before stddef.h include
>
> sysdeps/unix/sysv/linux/scsi/sg.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/scsi/sg.h b/sysdeps/unix/sysv/linux/scsi/sg.h
> index 9cad76e..68f57f2 100644
> --- a/sysdeps/unix/sysv/linux/scsi/sg.h
> +++ b/sysdeps/unix/sysv/linux/scsi/sg.h
> @@ -26,6 +26,8 @@
> #define _SCSI_SG_H 1
>
> #include <features.h>
> +#define __need_size_t
> +#include <stddef.h>
>
>
> /* New interface introduced in the 3.x SG drivers follows */
>
Reviewed-by: Carlos O'Donell <codonell@redhat.com>
Looks good to me.
Cheers,
Carlos.