This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] take3: fix tst-pthread-getattr test case

On Fri, 27 Jul 2012 22:38:56 -0700 (PDT), Roland wrote:
> I did tell you about that one...  When there's fiddly stuff and casts

I fixed one and missed another -- that was careless of me.

> Modulo those nits, this now looks fine to me.  (Yes, this all really
> was excessive style detail for a mere test case, but I am incurably
> pedantic that way, and I flatter myself it's good education for you
> and everyone else newish to the project who bothers to read it.  Many
> kudos and thanks for taking it all with such grace.)

I have pushed the fix with those two minor changes. Thanks for the very
detailed review -- it definitely is good education :)

Regards,
Siddhesh
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]