This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: tst-pthread-getattr changes break sparc

> I kept this signed because I am checking it for < 0 later. Would you
> prefer size_t here and then a cast to ssize_t during the check? I don't
> really have a preference either way.

I'd just never set the global if sysconf returns -1.
Frankly, not bothering to check for sysconf failure is pretty reasonable here.

> > > +  stack_limit.rlim_cur = _MIN(stacksize - pagesize + 1,
> > > MAX_STACK_SIZE);
> > 
> > Space before paren.  Where does _MIN come from?
> 
> I have defined _MIN earlier in the test case.

Ok.  I think we always have MIN/MAX in <sys/param.h> on every configuration.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]