This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x32 support to ldconfig

> 	* sysdeps/unix/sysv/linux/x86_64/ldconfig.h:
> 	(SYSDEP_KNOWN_INTERPRETER_NAMES): Add /libx32/ld-linux-x32.so.2.

Sorry, I misread and led you astray.  This one shouldn't have the trailing
colon on the first line, because the next line is just wrapped from what
would have been "ldconfig.h (SYSDEP_KNOWN_INTERPRETER_NAMES):".
The other one has it because what follows is a sentence that applies
to the file rather than to one an entity within it.

> +  if (!ret && !file_flag)
> +    *flag = file_flag;

The second test is inverted, no?

> --- a/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> +++ b/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> @@ -35,8 +35,18 @@ process_elf_file (const char *file_name, const char *lib, int *flag,

Hmm.  Perhaps x86_64/readelflib.c should just #include the i386 file
after defining a macro that says not to handle EM_IA_64.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]