This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add x32 support to ldconfig
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Mar 2012 11:42:07 -0700 (PDT)
- Subject: Re: PATCH: Add x32 support to ldconfig
- References: <20120316174742.GA7615@intel.com>
> 2012-03-16 H.J. Lu <hongjiu.lu@intel.com>
>
> * elf/cache.c (print_entry): Handle FLAG_X8664_LIBX32.
>
> * sysdeps/generic/ldconfig.h (FLAG_X8664_LIBX32): New.
Drop that blank line and invert the order. Say "New macro".
> * sysdeps/unix/sysv/linux/x86_64/dl-cache.h (add_system_dir): New
> Don't include <sysdeps/unix/sysv/linux/sparc/dl-cache.h>.
Write it like this:
* sysdeps/unix/sysv/linux/x86_64/dl-cache.h:
Don't include <sysdeps/unix/sysv/linux/sparc/dl-cache.h>.
(add_system_dir): New macro.
> --- a/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> +++ b/sysdeps/unix/sysv/linux/x86_64/readelflib.c
> @@ -35,8 +35,18 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
While you're here, it seems appropriate to lift the e_machine sanity check
above the if and make it accept only EM_{386,X86_64} (unconditionally)
and EM_IA_64 (only for ELFCLASS64).
Thanks,
Roland