This is the mail archive of the
mailing list for the glibc project.
Re: [Patch] Another fix for cycle detection
-----BEGIN PGP SIGNED MESSAGE-----
On 01/23/12 15:03, Roland McGrath wrote:
>> I've already seen it overflow 8 bit signed, seems silly to flip
>> to an unsigned which doesn't give us that much headroom. But if
>> that's what you'd prefer, I'll do it.
> If it has exceeded 127 in real-world cases, then going to 65535
> seems reasonable. But any real-world case having exceeded the
> limit indicates that explicit overflow detection is warranted.
It certainly has exceeded 127 in real world cases :( A quick survey
of /usr/bin/* on my F16 box shows dozens of executables that have
already exceeded 127 libraries. Right now the largest is digikam at
182 DSO dependencies according to ldd.
So, pending a resolution on the prior patch, ISTM the way to go is 64k
+ overflow checking.
>> In case it's not obvious, this patch is pointless without last
>> week's fix to cycle detection:
> That's a sufficiently more complex and subtle change that it merits
> more careful review than this one needed, and I haven't looked at
> it in detail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----