This is the mail archive of the
mailing list for the glibc project.
Re: [Patch] Another fix for cycle detection
-----BEGIN PGP SIGNED MESSAGE-----
On 01/23/12 14:47, Roland McGrath wrote:
> I think it's clearer to use a type like uint16_t.
That'd be fine with me...
> If overflow is a concern, then there should be an explicit overflow
> check. How about starting out with uint8_t and overflow checking?
I've already seen it overflow 8 bit signed, seems silly to flip to an
unsigned which doesn't give us that much headroom. But if that's what
you'd prefer, I'll do it.
In case it's not obvious, this patch is pointless without last week's
fix to cycle detection:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----