This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix PR debug/33155: Don't add DW_AT_MIPS_linkage_name for C functions

The attached fixes GCC bug

by preventing the addition of DW_AT_MIPS_linkage_name for C functions.
On MS Windows targets, the external assembler name of __stdcall functions are
mangled in  C as well as C++ by the addition of an '@n' suffix.
GDB however does not appear to  handle DW_AT_MIPS_linkage_name for C functions.

Should this be addressed in gdb sources rather than in GCC?

Tested on i686-pc-mingw32 with GNU gdb (cygwin-special) .

2008-04-27  Danny Smith  <>

	PR debug/33155
        * dwarf2out.c (is c): New function.
        (add_name_and_src_coords_attributes): Don't add
         DW_AT_MIPS_linkage_name if is_c ().

Index: dwarf2out.c
--- dwarf2out.c	(revision 134695)
+++ dwarf2out.c	(working copy)
@@ -4190,6 +4190,7 @@
 static unsigned get_AT_unsigned (dw_die_ref, enum dwarf_attribute);
 static inline dw_die_ref get_AT_ref (dw_die_ref, enum dwarf_attribute);
 static bool is_c_family (void);
+static bool is_c (void);
 static bool is_cxx (void);
 static bool is_java (void);
 static bool is_fortran (void);
@@ -5570,6 +5571,17 @@
 	  || lang == DW_LANG_C_plus_plus || lang == DW_LANG_ObjC_plus_plus);

+/* Return TRUE if the language is C.  */
+static inline bool
+is_c (void)
+  unsigned int lang = get_AT_unsigned (comp_unit_die, DW_AT_language);
+  return (lang == DW_LANG_C || lang == DW_LANG_C89
+	  || lang == DW_LANG_C99 || lang == DW_LANG_ObjC);
 /* Return TRUE if the language is C++.  */

 static inline bool
@@ -11556,7 +11568,7 @@
 	  && DECL_ASSEMBLER_NAME (decl) != DECL_NAME (decl)
 	  && !DECL_ABSTRACT (decl)
 	  && !(TREE_CODE (decl) == VAR_DECL && DECL_REGISTER (decl))
-	  && !is_fortran ())
+	  && !is_fortran () && !is_c ())
 	add_AT_string (die, DW_AT_MIPS_linkage_name,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]