Re: [PATCH 15/58] gdbserver: turn target op 'look_up_symbols' into a method

[Pedro Alves <palves at redhat dot com>]

On 2/11/20 9:01 AM, Tankut Baris Aktemur wrote:
> @@ -476,6 +468,13 @@ public:
>       Returns 0 on success and errno on failure.  */
>    virtual int write_memory (CORE_ADDR memaddr, const unsigned char *myaddr,
>  			    int len) = 0;
> +
> +  /* Query GDB for the values of any symbols we're interested in.
> +     This function is called whenever we receive a "qSymbols::"
> +     query, which corresponds to every time more symbols (might)
> +     become available.  NULL if we aren't interested in any
> +     symbols.  */

This "NULL if we aren't interested ..." remark no longer makes
sense, since a method can never be null.  Please double-check
whether other methods need similar adjustment as well.

> +  virtual void look_up_symbols ();

Thanks,
Pedro Alves