This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/58] gdbserver: turn target op 'create_inferior' into a method

On 2/11/20 9:01 AM, Tankut Baris Aktemur wrote:
> -static int
> -linux_create_inferior (const char *program,
> -		       const std::vector<char *> &program_args)
> +int
> +linux_process_target::create_inferior (
> +    const char *program, const std::vector<char *> &program_args)

No '(' at end of line, please.  You can either write:

linux_process_target::create_inferior 
  (const char *program, const std::vector<char *> &program_args)

... with two leading spaces, or:

linux_process_target::create_inferior (const char *program, 
                                       const std::vector<char *> &program_args)

since that fits in 79 cols.

The occurs in a number of other spots in the series, but I won't
comment on them.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]