Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c

[Kamil Rytarowski <n54 at gmx dot com>]

On 27.01.2020 13:38, Christian Biesinger via gdb-patches wrote:
> On Fri, Jan 24, 2020 at 5:37 PM Kamil Rytarowski <n54@gmx.com> wrote:
>>
>> On 24.01.2020 17:01, Christian Biesinger wrote:
>>> On Fri, Jan 24, 2020 at 4:49 PM Kamil Rytarowski <n54@gmx.com> wrote:
>>>>
>>>> On 24.01.2020 16:35, Christian Biesinger via gdb-patches wrote:
>>>>> On Fri, Jan 24, 2020 at 4:23 PM Kamil Rytarowski <n54@gmx.com> wrote:
>>>>>>
>>>>>> On 24.01.2020 15:53, Christian Biesinger via gdb-patches wrote:
>>>>>>> Hi Kamil,
>>>>>>>
>>>>>>> I have a related question. NetBSD applied this patch:
>>>>>>> https://www.mail-archive.com/tech@openbsd.org/msg44100.html
>>>>>>>
>>>>>>
>>>>>> Is this the right link?
>>>>>
>>>>> Yeah -- that patch changes a system header at the top and patches GDB
>>>>> at the bottom.
>>>>>
>>>>
>>>> This is not a change in NetBSD, so it is unrelated.
>>>
>>> My apologies, I completely misread that. I'll see if I can find where
>>> NetBSD changed their FP register data structure, or perhaps your
>>> downstream patch will still work (although that probably has to come
>>> from one of y'all for copyright reasons?)
>>>
>>
>> Please cherry-pick what you need and I will find the original author.
>> Many people in NetBSD have FSF papers done.
> 
> Thanks. I think this patch would probably be the most important since
> it fixes a compile error:
> https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_arm-nbsd-nat.c
> 
> However, I don't understand why arm_netbsd_core_fns /
> fetch_core_registers was added. As far as I can tell, because that
> struct uses bfd_target_unknown_flavour and default_core_sniffer, it
> will never be used.
> 
> Christian
> 

This looks like a leftover after a.out. It was removed upstream and we
by a mistake keep it locally as a local modification.

commit 1736a7bd96e8927c3f889a35f9153df4fd19d833
Author: Pedro Alves <palves@redhat.com>
Date:   Fri Dec 9 16:08:49 2016 +0000

    gdb: Remove support for obsolete OSABIs and a.out

    gdb/ChangeLog:
    2016-12-09  Pedro Alves  <palves@redhat.com>

a.out should be removed.

We switched to ELF back in NetBSD 1.6/2.0 and don't have toolchain for it.

We still support running old a.out binaries and plan to do it in
foreseeable future, but attaching a debugger to these processes is not
our priority.

Attachment: signature.asc
Description: OpenPGP digital signature