This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH 4/4] gdbserver: Add RISC-V/Linux support
- From: "Maciej W. Rozycki" <macro at wdc dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, Jim Wilson <jimw at sifive dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>, Palmer Dabbelt <palmer at dabbelt dot com>, guoren at kernel dot org, lifang_xia at c-sky dot com, yunhai_shang at c-sky dot com, jiangshuai_li at c-sky dot com
- Date: Fri, 24 Jan 2020 19:08:06 +0000 (GMT)
- Subject: Re: [RFC][PATCH 4/4] gdbserver: Add RISC-V/Linux support
- Ironport-sdr: uANNfqWJA+YBRsJPxfju9K0riAnXnsrwW+d2HHHW2zHTZ0vU6PS47gYgAIL0K6I75/Pv1qRwe1 2S84KdbF4QawZ0VtkFU6nKoiNCZ9WIY1W5qgCLVKLDQrXzUksIWajMaaIUcvWQWtQe8KOpjssb ZeiLWbSPKsnRNCqGgkqKrL6XjoRPrV1oEJY4AU4cmcuM5oFQ07I4Kk/cetBkIJGreLpUBql9ft yWU/EC2xggiIyW3XVn98rVl0zSof0ns/IDcOIrEl7FvjxTkxyGrxNDhgnKb9d7aUpeFTgHS9hR Hh8=
- Ironport-sdr: /SLWqtRDImDdH1+Lh+3ckAM6e7pepFaoEbz9g5712We0L+pl3Le33QXlfeINXjIJcFPmwLHPM/ uQn441glCXv/X6ojQNqUsYwjFloi4pqVTiNhNdnmfJTe9JEgaWk0FxzEOX2tUwf1EMyuevbUEV 4GiGvPjMc1T3/fx+bGL9neImPucU/ToCF3tP0rOFjwKONUxWxfaAqRcn+T8HmmvqTWywWq6wQJ +CmL3Ij9cMIjOlnXoSZiQq70u+ZQmbsh53irDdecwt6mDVrmGxSzZp+vXEYUHFnApfTUEU66z3 QOrwWzee4d2bp03tJYXtb1CM
- Ironport-sdr: 72RW2f7dFfp9noQuZDBotj8mYNcCIUepKWoQm6pfVPCmEe0XAxcJlvScj01NGg49KQCbFFlQ9f G9wWQ9rFqFZoICe4C2PHM6IHFPFtj6LW8uiPEyBD+XOcx0tchj1RbT7svBW+gU8y62GNOh+nd0 hNGfQpcJb0cgDO37dbgsdwKKUWySI3TRWtZkmFTK3ua2CINIY7QpLmFcgbNIs2RpCq+l4n0YFN AQdPDeISUq7tUbyyNCHFoaukpHAz2ytpCsHHawq/80j3w4OFzVzkylMb9k8rHL9vIGX9/ffjYy 8/g=
- References: <alpine.LFD.2.21.2001231412510.14118@redsun52.ssa.fujisawa.hgst.com> <alpine.LFD.2.21.2001231518180.14118@redsun52.ssa.fujisawa.hgst.com> <874kwlu9xg.fsf@tromey.com>
- Wdcironportexception: Internal
On Thu, 23 Jan 2020, Tom Tromey wrote:
> Maciej> Implement RISC-V/Linux support for both RV64 and RV32 systems, including
> Maciej> XML target description handling based on features determined, GPR and
> Maciej> FPR regset support including dynamic sizing of the latter, and software
> Maciej> breakpoint handling.
>
> I saw a couple of small nits here.
Thanks for looking through my proposal!
> Maciej> Also handle a glibc bug where ELF_NFPREG is defined in terms of NFPREG,
> Maciej> however NFPREG is nowhere defined.
>
> In case you haven't already, please report this to glibc.
Yep, see: <https://sourceware.org/ml/libc-alpha/2019-10/msg00233.html>,
and the discussion downthread.
> Maciej> +/* Implementation of linux_target_ops method "regs_info". */
> Maciej> +
> Maciej> +static const struct regs_info *
> Maciej> +riscv_regs_info (void)
>
> We stopped using "(void)" in new code, in favor of just "()".
> This showed up in a few spots.
Right, I'm pretty much in the C world still; will fix that in the next
iteration.
Maciej