This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 18/24] Multi-target support
- From: Simon Marchi <simark at simark dot ca>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Mon, 13 Jan 2020 10:59:39 -0500
- Subject: Re: [PATCH v2 18/24] Multi-target support
- References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-19-palves@redhat.com> <113c6953-3621-c61b-e318-19806805e878@simark.ca> <5a65f85e-89cb-fd6c-469d-250348f6c295@redhat.com>
On 2020-01-13 10:10 a.m., Pedro Alves wrote:
> On 1/12/20 7:57 PM, Simon Marchi wrote:
>> On 2019-10-17 6:50 p.m., Pedro Alves wrote:
>>> This commit adds multi-target support to GDB. What this means is that
>>> with this commit, GDB can now be connected to different targets at the
>>> same time. E.g., you can debug a live native process and a core dump
>>> at the same time, connect to multiple gdbservers, etc.
>>>
>>> ...
>>
>> remote-sim.c needs to be updated to. The patch below makes it build, although
>> I have not tried it (I don't have time right now to re-figure out again how do
>> do it :)).
>>
>
> Sorry about this. I don't know how I missed it.
>
> The patch look good to me. One nit:
>
>> /* Callback for iterate_over_inferiors. Called (indirectly) by
>> gdbsim_close(). */
>
> This comment is now stale.
I changed it to:
/* Helper for gdbsim_target::close. */
The comment on gdbsim_target::close already explains what is done when closing.
Pushed with that fixed, thanks.
Simon