This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 18/24] Multi-target support
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simark at simark dot ca>, gdb-patches at sourceware dot org, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Mon, 13 Jan 2020 15:10:06 +0000
- Subject: Re: [PATCH v2 18/24] Multi-target support
- References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-19-palves@redhat.com> <113c6953-3621-c61b-e318-19806805e878@simark.ca>
On 1/12/20 7:57 PM, Simon Marchi wrote:
> On 2019-10-17 6:50 p.m., Pedro Alves wrote:
>> This commit adds multi-target support to GDB. What this means is that
>> with this commit, GDB can now be connected to different targets at the
>> same time. E.g., you can debug a live native process and a core dump
>> at the same time, connect to multiple gdbservers, etc.
>>
>> ...
>
> remote-sim.c needs to be updated to. The patch below makes it build, although
> I have not tried it (I don't have time right now to re-figure out again how do
> do it :)).
>
Sorry about this. I don't know how I missed it.
The patch look good to me. One nit:
> /* Callback for iterate_over_inferiors. Called (indirectly) by
> gdbsim_close(). */
This comment is now stale.
>
> -static int
> -gdbsim_close_inferior (struct inferior *inf, void *arg)
> +void
> +gdbsim_target::close_one_inferior (inferior *inf)
> {
Thanks,
Pedro Alves