This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Add a fast_hash function in common-utils
- From: "Sergio Durigan Junior (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 15 Oct 2019 19:28:49 -0400
- Subject: [review] Add a fast_hash function in common-utils
- Auto-submitted: auto-generated
- References: <gerrit.1571050562000.I77cac0d9aa78fc65316a2af449f52edcae72dc9b@gnutoolchain-gerrit.osci.io>
- Reply-to: sergiodj at redhat dot com, sergiodj at redhat dot com, cbiesinger at google dot com, gdb-patches at sourceware dot org
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
LGTM assuming that the two minor nits are fixed. Thanks!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h
File gdb/utils.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.h@572
PS1, Line 572: extern unsigned int fast_hash (const char* str, size_t len);
You need a comment describing what the function does here.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c
File gdb/utils.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38/1/gdb/utils.c@3439
PS1, Line 3439: unsigned int
And you need a simple comment here saying
/* See utils.h. */