This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Use libxxhash for hashing, if present
- From: "Sergio Durigan Junior (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 15 Oct 2019 19:25:38 -0400
- Subject: [review] Use libxxhash for hashing, if present
- Auto-submitted: auto-generated
- References: <gerrit.1571050562000.Icab218388b9f829522ed3977f04301ae6d4fc4ca@gnutoolchain-gerrit.osci.io>
- Reply-to: sergiodj at redhat dot com, sergiodj at redhat dot com, cbiesinger at google dot com, gdb-patches at sourceware dot org
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Aside from the minor nit of missing whitespace, this LGTM. Thanks!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/1/gdb/utils.c
File gdb/utils.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/1/gdb/utils.c@3447
PS1, Line 3447: return XXH64(str, len, 0);
Missing whitespace between function name and open parenthesis.