This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Create xml-builtin.h to declare xml_builtins
- From: "Christian Biesinger (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at sourceware dot org>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Tue, 15 Oct 2019 18:36:22 -0400
- Subject: [review] Create xml-builtin.h to declare xml_builtins
- Auto-submitted: auto-generated
- References: <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
- Reply-to: cbiesinger at google dot com, simon dot marchi at polymtl dot ca, tromey at sourceware dot org, cbiesinger at google dot com, gdb-patches at sourceware dot org
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 2:
> Patch Set 1:
>
> (1 comment)
>
> Thanks for the patch.
>
> I'm not totally sure that the new .h belongs in gdb. On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport. On the other hand, I broke that rule already with alloc.c.
Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport?
> I did find a nit though.
Thanks, fixed.