This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Create xml-builtin.h to declare xml_builtins
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Wed, 16 Oct 2019 10:23:59 -0400
- Subject: [review] Create xml-builtin.h to declare xml_builtins
- Auto-submitted: auto-generated
- References: <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, simon dot marchi at polymtl dot ca, cbiesinger at google dot com, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 2: Code-Review+2
> Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport?
I don't see that in my build. I looked for xml-builtin.o in gdbserver,
and I dug through gdbserver/Makefile.in a bit.
I do see xml-builtin-generated in the Makefile, but that seems to be
a second copy, built locally. It's not made in my build for whatever reason.
Anyway, no, you don't have to change anything. Thanks for doing this.