Change in binutils-gdb[master]: Add initial compile command support to RISC-V port.

["Andrew Burgess (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Andrew Burgess has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42 )

Change subject: Add initial compile command support to RISC-V port.
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

I'm happy with this if you change to using std::string as described in the comment.

Thanks,
Andrew

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c 
File gdb/riscv-tdep.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42/1/gdb/riscv-tdep.c@3070 
PS1, Line 3070:   char string[64];
I think using std::string and then just 'string += "some text";' would be preferred.



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/42
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I315ce8de7789ddf7bdd3b532f917519464941294
Gerrit-Change-Number: 42
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Wilson <jimw@sifive.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Mon, 14 Oct 2019 22:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment