This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Mark guile_{extension_,}script_ops as static
- From: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Christian Biesinger via gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 9 Oct 2019 13:19:39 -0500
- Subject: Re: [PATCH] Mark guile_{extension_,}script_ops as static
- References: <20191007223851.101950-1-cbiesinger@google.com> <8736g1eroj.fsf@tromey.com>
- Reply-to: Christian Biesinger <cbiesinger at google dot com>
On Wed, Oct 9, 2019 at 12:48 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> This makes it clearer that the structs are only used in this file. It
> Christian> required moving the definition of extension_language_guile further
> Christian> down in the file, because static structs can't be forward-declared.
>
> Christian> gdb/ChangeLog:
>
> Christian> 2019-10-07 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * guile/guile.c (guile_extension_script_ops): Remove forward
> Christian> declaration and mark as static.
> Christian> (guile_script_ops): Likewise.
> Christian> (extension_language_guile): Move further down in the file so
> Christian> it can reference the definitions for guile_{extension_,}script_ops.
>
> This is ok, thanks.
Thanks, pushed:
To ssh://sourceware.org/git/binutils-gdb.git
1d3787499d6..6a25e8a290e HEAD -> master
Christian