This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c
- From: Tom Tromey <tom at tromey dot com>
- To: Andreas Arnez <arnez at linux dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Alan Hayward <alan dot hayward at arm dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Wed, 09 Oct 2019 11:58:32 -0600
- Subject: Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c
- References: <m3pnj77a5s.fsf@oc0404454431.ibm.com>
>>>>> "Andreas" == Andreas Arnez <arnez@linux.ibm.com> writes:
Andreas> Some of the comparison functions in infcall-nested-structs.c contain
Andreas> redundant comparisons like a.<some_field> == a.<some_field> instead of
Andreas> a.<some_field> == b.<some_field>. They were introduced with this commit:
Andreas> 36eb4c5f9bbe6 - "infcall-nested-structs: Test up to five fields"
Andreas> Fix the redundant comparisons.
Andreas> gdb/testsuite/ChangeLog:
Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01)
Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02)
Andreas> (cmp_struct_05_01, cmp_struct_static_02_01)
Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant
Andreas> comparisons.
Thank you. This looks reasonable to me. I think you could have put it
in under the obvious rule, even.
Tom