This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.

From: Tom Tromey <tom at tromey dot com>
To: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
Cc: Tom Tromey <tom at tromey dot com>, Christian Biesinger <cbiesinger at google dot com>
Date: Tue, 08 Oct 2019 06:46:09 -0600
Subject: Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
References: <20191007175734.257671-1-cbiesinger@google.com> <878spwqjv1.fsf@tromey.com> <CAPTJ0XE4pNfJHdYF4gmp82NcvaRNL6KoozWW0r9sntTR6Pw0Ow@mail.gmail.com>

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

>> It can be done as-is though by changing it to a const char *, then
>> wrapping the literal in N_(...), and changing the uses to _(...).

Christian> Thanks. It seems to work for me even without changing to const char*,
Christian> so I'll send a patch momentarily which does that.

Oh yeah, duh.  N_ is just a marker for xgettext, and doesn't actually do
anything.

Tom

References:
- [PATCH] Move declaration of lang_frame_mismatch_warn to header.
  - From: Christian Biesinger via gdb-patches
- Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
  - From: Tom Tromey
- Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
  - From: Christian Biesinger via gdb-patches

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]