This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
- From: Tom Tromey <tom at tromey dot com>
- To: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
- Cc: Christian Biesinger <cbiesinger at google dot com>
- Date: Mon, 07 Oct 2019 16:19:30 -0600
- Subject: Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header.
- References: <20191007175734.257671-1-cbiesinger@google.com>
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> gdb/ChangeLog:
Christian> 2019-10-07 Christian Biesinger <cbiesinger@google.com>
Christian> * language.c (lang_frame_mismatch_warn): Make const and move
Christian> comment...
Christian> * language.h (lang_frame_mismatch_warn): ... here. Also add
Christian> declaration.
Christian> * top.c (lang_frame_mismatch_warn): Remove declaration.
Thanks.
Maybe it would be better to just have a function to print this message.
That would make it easier to gettext-ize.
It can be done as-is though by changing it to a const char *, then
wrapping the literal in N_(...), and changing the uses to _(...).
Tom