This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Fix alias command not detecting non matching prefix & sometimes asserting.

From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 25 Jun 2019 19:42:45 +0200
Subject: Re: [RFA] Fix alias command not detecting non matching prefix & sometimes asserting.
References: <20190623154106.13224-1-philippe.waroquiers@skynet.be> <87a7e590uw.fsf@tromey.com>

On Tue, 2019-06-25 at 08:49 -0600, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
> 
> Philippe> gdb/ChangeLog
> Philippe> 2019-06-23  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
> Philippe> 	* cli/cli-cmds.c (alias_command): Compare the alias prefix
> Philippe> 	with the command prefix.
> 
> Philippe> gdb/testsuite/ChangeLog
> Philippe> 2019-06-23  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
> Philippe> 	* gdb.base/alias.exp: Test non matching/non existing prefixes.
> 
> Thank you for the patch.  This is ok.
Thanks for the review, pushed (after updating the ChangeLogs ...)

Philippe

References:
- [RFA] Fix alias command not detecting non matching prefix & sometimes asserting.
  - From: Philippe Waroquiers
- Re: [RFA] Fix alias command not detecting non matching prefix & sometimes asserting.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]