This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] arm-tdep: replace arm_mapping_symbol VEC with std::vector
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, Alan Hayward <Alan dot Hayward at arm dot com>
- Date: Tue, 25 Jun 2019 14:00:12 -0400
- Subject: Re: [PATCH 1/2] arm-tdep: replace arm_mapping_symbol VEC with std::vector
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x5PI0EJl026144
- References: <20190625013748.11003-1-simon.marchi@polymtl.ca> <87mui591xa.fsf@tromey.com>
On 2019-06-25 10:26 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> This patch replaces VEC (arm_mapping_symbol) with an std::vector. No
> Simon> functional changes intended.
>
> Thanks for doing this. I had a couple of nits, nothing serious.
>
> Simon> struct arm_per_objfile
> Simon> {
> Simon> - VEC(arm_mapping_symbol_s) **section_maps;
> Simon> + arm_per_objfile (size_t num_sections)
>
> Should be explicit. Also probably this class should use
> DISABLE_COPY_AND_ASSIGN.
Thanks, I have done both locally.
Simon