This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH][gdb] Write index for dwz -m file
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom de Vries <tdevries at suse dot de>, gdb-patches at sourceware dot org
- Date: Sun, 16 Jun 2019 13:22:31 -0400
- Subject: Re: [PING][PATCH][gdb] Write index for dwz -m file
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x5GHMWLw001427
- References: <20190507144207.GA17626@delia> <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> <4c7917b3-cdf0-0f17-ab6c-e76d891dfd3b@polymtl.ca> <0428a4a6-3ed8-17ee-0161-52ee12a4d941@suse.de>
On 2019-06-16 6:43 a.m., Tom de Vries wrote:
> On 13-05-19 15:56, Simon Marchi wrote:
>> On 2019-05-13 8:22 a.m., Tom de Vries wrote:
>>> On 11-05-19 04:36, Simon Marchi wrote:
>>>> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile)
>>>>
>>>> if (debug_index_cache)
>>>> printf_unfiltered ("index cache: writing index cache for objfile %s\n",
>>>> - objfile_name (obj));
>>>> + objfile_name (obj));
>>>>
>>>> /* Write the index itself to the directory, using the build id as the
>>>> filename. */
>>>
>>> LGTM.
>>>
>>> [ I'm not sure if this white-space-only change should be included though. ]
>>>
>>> Thanks,
>>> - Tom
>>
>> Hmm probably not, but I am tempted to leave it in, since I am touching the lines around it (and it
>> fixes the wrong indentation).
>>
>> I will leave this patch up for review for a week or so, to give the others a chance to comment.
>>
>
> Ping.
>
> Thanks,
> - Tom
Ah, thanks for reminding me. I don't have so much time to spend on GDB these days, so things
easily get forgotten.
I'll give it a last look and push it.
Simon