This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PING][PATCH][gdb] Write index for dwz -m file


On 13-05-19 15:56, Simon Marchi wrote:
> On 2019-05-13 8:22 a.m., Tom de Vries wrote:
>> On 11-05-19 04:36, Simon Marchi wrote:
>>> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile)
>>>
>>>        if (debug_index_cache)
>>>          printf_unfiltered ("index cache: writing index cache for objfile %s\n",
>>> -			 objfile_name (obj));
>>> +			   objfile_name (obj));
>>>
>>>        /* Write the index itself to the directory, using the build id as the
>>>           filename.  */
>>
>> LGTM.
>>
>> [ I'm not sure if this white-space-only change should be included though. ]
>>
>> Thanks,
>> - Tom
> 
> Hmm probably not, but I am tempted to leave it in, since I am touching the lines around it (and it
> fixes the wrong indentation).
> 
> I will leave this patch up for review for a week or so, to give the others a chance to comment.
> 

Ping.

Thanks,
- Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]