[PATCH 0/4] Changes around annotate_source_line

[Andrew Burgess <andrew dot burgess at embecosm dot com>]

This series addresses Tom's comments to my first patch.

  #1 Removes the unused parameter from get_filename_and_charpos,

  #2 Is a new clean up, creating a new function to load a symtab's
     line_charpos data,

  #3 This is the original patch, updated to take account of the above
     two changes,

  #4 This make annotate_source_line a void function, and changes GDB
     to always print the source line, even when annotations are on.

I kept #4 separate as I worried that changing GDB in this way might
break some GUI that relies on annotations, and which we care about
enough to want to go back to the old behaviour - having a separate
patch allows that code to be reverted easily :)

Thanks,
Andrew

---

Andrew Burgess (4):
  gdb: Remove unused parameter
  gdb: New function to open source file and compute line charpos data
  gdb: Remove an update of current_source_line and current_source_symtab
  gdb: Don't allow annotations to influence what else GDB prints

 gdb/ChangeLog                      | 51 ++++++++++++++++++++++++++++++
 gdb/annotate.c                     | 27 +++++++++++++++-
 gdb/annotate.h                     | 10 ++++--
 gdb/source-cache.c                 |  8 ++---
 gdb/source.c                       | 56 ++++++++-------------------------
 gdb/source.h                       | 22 +++----------
 gdb/stack.c                        | 63 ++++++++++++++++++--------------------
 gdb/testsuite/ChangeLog            |  6 ++++
 gdb/testsuite/gdb.base/annota1.exp |  4 +--
 gdb/testsuite/gdb.cp/annota2.exp   |  1 +
 gdb/testsuite/gdb.cp/annota3.exp   |  2 +-
 11 files changed, 144 insertions(+), 106 deletions(-)

-- 
2.14.5