This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 0/4] Changes around annotate_source_line
>>>>> "Andrew" == Andrew Burgess <firstname.lastname@example.org> writes:
Andrew> This series addresses Tom's comments to my first patch.
Thanks for doing all of this.
Andrew> I kept #4 separate as I worried that changing GDB in this way might
Andrew> break some GUI that relies on annotations, and which we care about
Andrew> enough to want to go back to the old behaviour - having a separate
Andrew> patch allows that code to be reverted easily :)
Makes sense. I hope we should be safe, as the idea behind annotations
is that the metadata is self-contained and the UI generally should not
be looking at the user text. I guess I wouldn't be surprised if some
front end were parsing output -- but on the other hand the reason MI
exists is precisely so we don't have to keep CLI output consistent.
I read through the patches and they all look good to me.